diff options
author | Lai Jiangshan <laijs@linux.alibaba.com> | 2020-12-17 16:41:18 +0100 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2021-01-08 00:11:30 +0100 |
commit | 88bf56d04bc3564542049ec4ec168a8b60d0b48c (patch) | |
tree | 9de20433d909e333c8c118d2ee85ecfde6a01ae8 /drivers | |
parent | KVM: x86: change in pv_eoi_get_pending() to make code more readable (diff) | |
download | linux-88bf56d04bc3564542049ec4ec168a8b60d0b48c.tar.xz linux-88bf56d04bc3564542049ec4ec168a8b60d0b48c.zip |
kvm: check tlbs_dirty directly
In kvm_mmu_notifier_invalidate_range_start(), tlbs_dirty is used as:
need_tlb_flush |= kvm->tlbs_dirty;
with need_tlb_flush's type being int and tlbs_dirty's type being long.
It means that tlbs_dirty is always used as int and the higher 32 bits
is useless. We need to check tlbs_dirty in a correct way and this
change checks it directly without propagating it to need_tlb_flush.
Note: it's _extremely_ unlikely this neglecting of higher 32 bits can
cause problems in practice. It would require encountering tlbs_dirty
on a 4 billion count boundary, and KVM would need to be using shadow
paging or be running a nested guest.
Cc: stable@vger.kernel.org
Fixes: a4ee1ca4a36e ("KVM: MMU: delay flush all tlbs on sync_page path")
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
Message-Id: <20201217154118.16497-1-jiangshanlai@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions