diff options
| author | Tong Zhang <ztong0001@gmail.com> | 2021-03-08 04:25:29 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-09 00:16:30 +0100 |
| commit | 3153724fc084d8ef640c611f269ddfb576d1dcb1 (patch) | |
| tree | b93f0677a75b2d9b63d906caa61ee62b4817cf97 /drivers | |
| parent | atm: fix a typo in the struct description (diff) | |
| download | linux-3153724fc084d8ef640c611f269ddfb576d1dcb1.tar.xz linux-3153724fc084d8ef640c611f269ddfb576d1dcb1.zip | |
atm: uPD98402: fix incorrect allocation
dev->dev_data is set in zatm.c, calling zatm_start() will overwrite this
dev->dev_data in uPD98402_start() and a subsequent PRIV(dev)->lock
(i.e dev->phy_data->lock) will result in a null-ptr-dereference.
I believe this is a typo and what it actually want to do is to allocate
phy_data instead of dev_data.
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/atm/uPD98402.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/uPD98402.c b/drivers/atm/uPD98402.c index 7850758b5bb8..239852d85558 100644 --- a/drivers/atm/uPD98402.c +++ b/drivers/atm/uPD98402.c @@ -211,7 +211,7 @@ static void uPD98402_int(struct atm_dev *dev) static int uPD98402_start(struct atm_dev *dev) { DPRINTK("phy_start\n"); - if (!(dev->dev_data = kmalloc(sizeof(struct uPD98402_priv),GFP_KERNEL))) + if (!(dev->phy_data = kmalloc(sizeof(struct uPD98402_priv),GFP_KERNEL))) return -ENOMEM; spin_lock_init(&PRIV(dev)->lock); memset(&PRIV(dev)->sonet_stats,0,sizeof(struct k_sonet_stats)); |