diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-05-31 14:55:04 +0200 |
|---|---|---|
| committer | Bryan Wu <cooloney@gmail.com> | 2013-06-21 01:21:33 +0200 |
| commit | fb277f5b3a15c895586545d3938dc869e760bec6 (patch) | |
| tree | ad8bc226b8b965e09bf59c776ed3cefca8503aa9 /drivers | |
| parent | leds: use platform_{get,set}_drvdata() (diff) | |
| download | linux-fb277f5b3a15c895586545d3938dc869e760bec6.tar.xz linux-fb277f5b3a15c895586545d3938dc869e760bec6.zip | |
leds: renesas-tpu: cleanup a small type issue
Static checkers complain that, although this is declared as an
unsigned long, we can only use the lower 32 bits. For anything
higher, we hit bugs widening then bitwise negate or wrapping bugs
doing the left shift.
From looking at the context, this is not a problem because we only
use 16 bits. I've changed some types to make it more clear.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/leds/leds-renesas-tpu.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/leds/leds-renesas-tpu.c b/drivers/leds/leds-renesas-tpu.c index 9483f1c1078d..adebf4931e1e 100644 --- a/drivers/leds/leds-renesas-tpu.c +++ b/drivers/leds/leds-renesas-tpu.c @@ -63,7 +63,7 @@ static DEFINE_SPINLOCK(r_tpu_lock); #define TGRC 8 /* Timer general register C (+0x20) */ #define TGRD 9 /* Timer general register D (+0x24) */ -static inline unsigned short r_tpu_read(struct r_tpu_priv *p, int reg_nr) +static inline u16 r_tpu_read(struct r_tpu_priv *p, int reg_nr) { struct led_renesas_tpu_config *cfg = p->pdev->dev.platform_data; void __iomem *base = p->mapbase; @@ -75,8 +75,7 @@ static inline unsigned short r_tpu_read(struct r_tpu_priv *p, int reg_nr) return ioread16(base + offs); } -static inline void r_tpu_write(struct r_tpu_priv *p, int reg_nr, - unsigned short value) +static inline void r_tpu_write(struct r_tpu_priv *p, int reg_nr, u16 value) { struct led_renesas_tpu_config *cfg = p->pdev->dev.platform_data; void __iomem *base = p->mapbase; @@ -93,7 +92,8 @@ static inline void r_tpu_write(struct r_tpu_priv *p, int reg_nr, static void r_tpu_start_stop_ch(struct r_tpu_priv *p, int start) { struct led_renesas_tpu_config *cfg = p->pdev->dev.platform_data; - unsigned long flags, value; + unsigned long flags; + u16 value; /* start stop register shared by multiple timer channels */ spin_lock_irqsave(&r_tpu_lock, flags); |