summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorMax Gurtovoy <maxg@mellanox.com>2018-01-31 17:31:26 +0100
committerSagi Grimberg <sagi@grimberg.me>2018-02-08 17:35:54 +0100
commit3096a739d2ccbfd6a626e388228a16558f76d79d (patch)
tree470d05e958496ec7ec6e0f62957374e4aa973b90 /drivers
parentnvme-rdma: use NVME_CTRL_CONNECTING state to mark init process (diff)
downloadlinux-3096a739d2ccbfd6a626e388228a16558f76d79d.tar.xz
linux-3096a739d2ccbfd6a626e388228a16558f76d79d.zip
nvme: delete NVME_CTRL_LIVE --> NVME_CTRL_CONNECTING transition
There is no logical reason to move from live state to connecting state. In case of initial connection establishment, the transition should be NVME_CTRL_NEW --> NVME_CTRL_CONNECTING --> NVME_CTRL_LIVE. In case of error recovery or reset, the transition should be NVME_CTRL_LIVE --> NVME_CTRL_RESETTING --> NVME_CTRL_CONNECTING --> NVME_CTRL_LIVE. Signed-off-by: Max Gurtovoy <maxg@mellanox.com> Reviewed-by: James Smart <james.smart@broadcom.com> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/nvme/host/core.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 86dca2919e19..1f9278364196 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -297,7 +297,6 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
case NVME_CTRL_CONNECTING:
switch (old_state) {
case NVME_CTRL_NEW:
- case NVME_CTRL_LIVE:
case NVME_CTRL_RESETTING:
changed = true;
/* FALLTHRU */