diff options
| author | Sebastian Biemueller <sebastian.biemueller@amd.com> | 2012-02-29 17:04:52 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2012-02-29 18:47:57 +0100 |
| commit | 108b0d348302be2b2f846bc8a8115f5b099a6196 (patch) | |
| tree | 206d8613c6eb6740fe13f0d80eb090c8b57473de /drivers | |
| parent | drm/radeon: fix uninitialized variable (diff) | |
| download | linux-108b0d348302be2b2f846bc8a8115f5b099a6196.tar.xz linux-108b0d348302be2b2f846bc8a8115f5b099a6196.zip | |
drm/radeon/kms/vm: fix possible bug in radeon_vm_bo_rmv()
The bo is removed from the list at the top of
radeon_vm_bo_rmv(), but then the list is used
in radeon_vm_bo_update_pte() to look up the vm.
remove the bo_list entry at the end of the
function instead.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Jerome Glisse <j.glisse@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/radeon/radeon_gart.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c index 010dad8b66ae..c58a036233fb 100644 --- a/drivers/gpu/drm/radeon/radeon_gart.c +++ b/drivers/gpu/drm/radeon/radeon_gart.c @@ -597,13 +597,13 @@ int radeon_vm_bo_rmv(struct radeon_device *rdev, if (bo_va == NULL) return 0; - list_del(&bo_va->bo_list); mutex_lock(&vm->mutex); radeon_mutex_lock(&rdev->cs_mutex); radeon_vm_bo_update_pte(rdev, vm, bo, NULL); radeon_mutex_unlock(&rdev->cs_mutex); list_del(&bo_va->vm_list); mutex_unlock(&vm->mutex); + list_del(&bo_va->bo_list); kfree(bo_va); return 0; |