summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJann Horn <jannh@google.com>2019-10-18 17:39:46 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-21 18:30:49 +0200
commit834c7360f92ad88155c5628eb10d60419ebaa0df (patch)
treeb61f7c4973f7521c4468ede7c912971c80e50f77 /drivers
parentbinder: Use common definition of SZ_1K (diff)
downloadlinux-834c7360f92ad88155c5628eb10d60419ebaa0df.tar.xz
linux-834c7360f92ad88155c5628eb10d60419ebaa0df.zip
binder: Remove incorrect comment about vm_insert_page() behavior
vm_insert_page() does increment the page refcount, and just to be sure, I've confirmed it by printing page_count(page[0].page_ptr) before and after vm_insert_page(). It's 1 before, 2 afterwards, as expected. Fixes: a145dd411eb2 ("VM: add "vm_insert_page()" function") Signed-off-by: Jann Horn <jannh@google.com> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Link: https://lore.kernel.org/r/20191018153946.128584-1-jannh@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/android/binder_alloc.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index d42a8b2f636a..2faada3e97fd 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -267,7 +267,6 @@ static int binder_update_page_range(struct binder_alloc *alloc, int allocate,
alloc->pages_high = index + 1;
trace_binder_alloc_page_end(alloc, index);
- /* vm_insert_page does not seem to increment the refcount */
}
if (mm) {
up_read(&mm->mmap_sem);