summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>2019-04-11 05:16:59 +0200
committerVinod Koul <vkoul@kernel.org>2019-04-14 12:03:26 +0200
commit7de8d238dd91dcb4c1200facdf7d510896927883 (patch)
tree48e5c880a69d45ee52362d1803f66baae169ede6 /drivers
parentsoundwire: intel: fix inversion in devm_kcalloc parameters (diff)
downloadlinux-7de8d238dd91dcb4c1200facdf7d510896927883.tar.xz
linux-7de8d238dd91dcb4c1200facdf7d510896927883.zip
soundwire: remove useless initializations
No need for explicit initialization of page and ssp fields, they are already zeroed with a memset. Detected with cppcheck: [drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/soundwire/bus.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 1cbfedfc20ef..688848637099 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -271,8 +271,6 @@ int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,
msg->dev_num = dev_num;
msg->flags = flags;
msg->buf = buf;
- msg->ssp_sync = false;
- msg->page = false;
if (addr < SDW_REG_NO_PAGE) { /* no paging area */
return 0;