diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2019-03-25 00:18:56 +0100 |
|---|---|---|
| committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2019-04-24 20:15:15 +0200 |
| commit | 22e8860cf8f777fbf6a83f2fb7127f682a8e9de4 (patch) | |
| tree | 55197fe3c217f1cc3b8985633dbef299448794b1 /drivers | |
| parent | net/ncsi: handle overflow when incrementing mac address (diff) | |
| download | linux-22e8860cf8f777fbf6a83f2fb7127f682a8e9de4.tar.xz linux-22e8860cf8f777fbf6a83f2fb7127f682a8e9de4.zip | |
net: ieee802154: fix missing checks for regmap_update_bits
regmap_update_bits could fail and deserves a check.
The patch adds the checks and if it fails, returns its error
code upstream.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ieee802154/mcr20a.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index c589f5ae75bb..8bb53ec8d9cf 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -533,6 +533,8 @@ mcr20a_start(struct ieee802154_hw *hw) dev_dbg(printdev(lp), "no slotted operation\n"); ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL1, DAR_PHY_CTRL1_SLOTTED, 0x0); + if (ret < 0) + return ret; /* enable irq */ enable_irq(lp->spi->irq); @@ -540,11 +542,15 @@ mcr20a_start(struct ieee802154_hw *hw) /* Unmask SEQ interrupt */ ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL2, DAR_PHY_CTRL2_SEQMSK, 0x0); + if (ret < 0) + return ret; /* Start the RX sequence */ dev_dbg(printdev(lp), "start the RX sequence\n"); ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL1, DAR_PHY_CTRL1_XCVSEQ_MASK, MCR20A_XCVSEQ_RX); + if (ret < 0) + return ret; return 0; } |