summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorFrank Li <Frank.Li@nxp.com>2024-03-23 16:34:51 +0100
committerVinod Koul <vkoul@kernel.org>2024-04-07 13:50:00 +0200
commit6aa60f79e6794bbbc571ea4e0501b9fcc26026e2 (patch)
tree43344a3fbcb1744224ea76f99d5de778452518cc /drivers
parentdmaengine: fsl-edma: remove 'slave_id' from fsl_edma_chan (diff)
downloadlinux-6aa60f79e6794bbbc571ea4e0501b9fcc26026e2.tar.xz
linux-6aa60f79e6794bbbc571ea4e0501b9fcc26026e2.zip
dmaengine: fsl-edma: add safety check for 'srcid'
Ensure that 'srcid' is a non-zero value to avoid dtb passing invalid 'srcid' to the driver. Signed-off-by: Frank Li <Frank.Li@nxp.com> Link: https://lore.kernel.org/r/20240323-8ulp_edma-v3-2-c0e981027c05@nxp.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/dma/fsl-edma-main.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 0a6e0c404027..2148a7f1ae84 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -115,6 +115,13 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
chan->device->privatecnt++;
fsl_chan = to_fsl_edma_chan(chan);
fsl_chan->srcid = dma_spec->args[1];
+
+ if (!fsl_chan->srcid) {
+ dev_err(&fsl_chan->pdev->dev, "Invalidate srcid %d\n",
+ fsl_chan->srcid);
+ return NULL;
+ }
+
fsl_edma_chan_mux(fsl_chan, fsl_chan->srcid,
true);
mutex_unlock(&fsl_edma->fsl_edma_mutex);