diff options
| author | Jan Kiszka <jan.kiszka@siemens.com> | 2023-11-10 17:13:08 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-11-11 20:49:21 +0100 |
| commit | 2bd5b559a1f391f05927bbb0b31381fa71c61e26 (patch) | |
| tree | 035bf1b972ee2164e3862a802152c38bec495763 /drivers | |
| parent | net: ti: icssg-prueth: Add missing icss_iep_put to error path (diff) | |
| download | linux-2bd5b559a1f391f05927bbb0b31381fa71c61e26.tar.xz linux-2bd5b559a1f391f05927bbb0b31381fa71c61e26.zip | |
net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region
We were just continuing in this case, surely not desired.
Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c index 3abbeba26f1b..411898a4f38c 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c @@ -2063,7 +2063,7 @@ static int prueth_probe(struct platform_device *pdev) &prueth->shram); if (ret) { dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret); - pruss_put(prueth->pruss); + goto put_pruss; } prueth->sram_pool = of_gen_pool_get(np, "sram", 0); @@ -2215,6 +2215,8 @@ free_pool: put_mem: pruss_release_mem_region(prueth->pruss, &prueth->shram); + +put_pruss: pruss_put(prueth->pruss); put_cores: |