summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorBruno Prémont <bonbons@linux-vserver.org>2010-08-06 10:08:04 +0200
committerJiri Kosina <jkosina@suse.cz>2010-08-06 14:53:10 +0200
commit1778ca298b06ec86af5fc9603447c379cbfb477b (patch)
treedd6e0c5d6c02d052bd2ebfffc1d16bba7a2a8cd6 /drivers
parentHID: picolcd: testing the wrong variable (diff)
downloadlinux-1778ca298b06ec86af5fc9603447c379cbfb477b.tar.xz
linux-1778ca298b06ec86af5fc9603447c379cbfb477b.zip
HID: picolcd: correct ordering of framebuffer freeing
Fix the free() ordering (which was never reached due to wrong check). Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/hid/hid-picolcd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
index c0bdebac5672..bc2e07740628 100644
--- a/drivers/hid/hid-picolcd.c
+++ b/drivers/hid/hid-picolcd.c
@@ -550,8 +550,8 @@ static void picolcd_fb_destroy(struct fb_info *info)
may_release = !*ref_cnt;
mutex_unlock(&info->lock);
if (may_release) {
- framebuffer_release(info);
vfree((u8 *)info->fix.smem_start);
+ framebuffer_release(info);
}
}