summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>2013-07-23 17:36:47 +0200
committerDan Williams <djbw@fb.com>2013-08-23 07:57:33 +0200
commite24775e41ffc59d9ae8c1f2a9a4ff9f79db0e573 (patch)
tree8419ff7f938e53c569ce87881ad559e1ec6036ea /drivers
parentdmatest: make module parameters writable (diff)
downloadlinux-e24775e41ffc59d9ae8c1f2a9a4ff9f79db0e573.tar.xz
linux-e24775e41ffc59d9ae8c1f2a9a4ff9f79db0e573.zip
dmatest: remove IS_ERR_OR_NULL checks of debugfs calls
There is a really little chance when we are able to create a directory and are not able to create nodes under it. So, this patch just removes those checks. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Dan Williams <djbw@fb.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/dma/dmatest.c17
1 files changed, 5 insertions, 12 deletions
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 91716f404c03..eae598986b81 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -1131,7 +1131,6 @@ static const struct file_operations dtf_results_fops = {
static int dmatest_register_dbgfs(struct dmatest_info *info)
{
struct dentry *d;
- int ret = -ENOMEM;
d = debugfs_create_dir("dmatest", NULL);
if (IS_ERR(d))
@@ -1142,24 +1141,18 @@ static int dmatest_register_dbgfs(struct dmatest_info *info)
info->root = d;
/* Run or stop threaded test */
- d = debugfs_create_file("run", S_IWUSR | S_IRUGO, info->root,
- info, &dtf_run_fops);
- if (IS_ERR_OR_NULL(d))
- goto err_node;
+ debugfs_create_file("run", S_IWUSR | S_IRUGO, info->root, info,
+ &dtf_run_fops);
/* Results of test in progress */
- d = debugfs_create_file("results", S_IRUGO, info->root, info,
- &dtf_results_fops);
- if (IS_ERR_OR_NULL(d))
- goto err_node;
+ debugfs_create_file("results", S_IRUGO, info->root, info,
+ &dtf_results_fops);
return 0;
-err_node:
- debugfs_remove_recursive(info->root);
err_root:
pr_err("dmatest: Failed to initialize debugfs\n");
- return ret;
+ return -ENOMEM;
}
static int __init dmatest_init(void)