diff options
| author | Billy Tsai <billy_tsai@aspeedtech.com> | 2020-10-19 06:50:26 +0200 |
|---|---|---|
| committer | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-10-26 15:51:57 +0100 |
| commit | 560b6ac37a87fcb78d580437e3e0bc2b6b5b0295 (patch) | |
| tree | e146b84c1ed9cafce628facc536cf5b2949f7852 /drivers | |
| parent | gpio: dwapb: Fix missing conversion to GPIO-lib-based IRQ-chip (diff) | |
| download | linux-560b6ac37a87fcb78d580437e3e0bc2b6b5b0295.tar.xz linux-560b6ac37a87fcb78d580437e3e0bc2b6b5b0295.zip | |
gpio: aspeed: fix ast2600 bank properties
GPIO_T is mapped to the most significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_T is input only. All
the other bits need to be 1 because GPIO_Q/R/S support both input and
output modes.
Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpio/gpio-aspeed.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index e44d5de2a120..b966f5e28ebf 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config = static const struct aspeed_bank_props ast2600_bank_props[] = { /* input output */ + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */ {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ { }, |