summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJacek Anaszewski <jacek.anaszewski@gmail.com>2018-12-10 10:29:57 +0100
committerJacek Anaszewski <jacek.anaszewski@gmail.com>2018-12-10 21:10:42 +0100
commitc4f7bd4a42758ed42cf7f7a5fd46e0b54ce23ad2 (patch)
tree93a640ac6a1b641784d7004c8e15244a550d5037 /drivers
parentleds: pwm: Use OF variant of LED registering function (diff)
downloadlinux-c4f7bd4a42758ed42cf7f7a5fd46e0b54ce23ad2.tar.xz
linux-c4f7bd4a42758ed42cf7f7a5fd46e0b54ce23ad2.zip
led: triggers: Break the for loop after default trigger is found
It is of no avail to continue iterating through registered triggers in the led_trigger_set_default() after the trigger to set has been found. Add "break" statement to fix this omission. Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/leds/led-triggers.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index 17d73db1456e..52b12e601ebe 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -200,8 +200,10 @@ void led_trigger_set_default(struct led_classdev *led_cdev)
down_read(&triggers_list_lock);
down_write(&led_cdev->trigger_lock);
list_for_each_entry(trig, &trigger_list, next_trig) {
- if (!strcmp(led_cdev->default_trigger, trig->name))
+ if (!strcmp(led_cdev->default_trigger, trig->name)) {
led_trigger_set(led_cdev, trig);
+ break;
+ }
}
up_write(&led_cdev->trigger_lock);
up_read(&triggers_list_lock);