diff options
| author | Stephen Boyd <swboyd@chromium.org> | 2018-05-31 08:23:43 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2018-06-04 09:46:42 +0200 |
| commit | df7c3bf24f546ab0e5a23b282d34850f2b8eb0d2 (patch) | |
| tree | 192125f20a87641b62b06a7be33fc7e14115f78f /drivers | |
| parent | mfd: cros_ec: Use devm_kzalloc for private data (diff) | |
| download | linux-df7c3bf24f546ab0e5a23b282d34850f2b8eb0d2.tar.xz linux-df7c3bf24f546ab0e5a23b282d34850f2b8eb0d2.zip | |
mfd: cros_ec_dev: Don't advertise junk features on failure
If the feature query fails during this driver's probe, we memset the
features bits to 0, but then we continue to overwrite that with whatever
junk we read back when the feature probing failed. In the case of a SPI
device, it may be complete junk, causing the caller of this function to
think certain features are present when they aren't. Don't copy over the
bad message on failure so we can fail more gracefully.
Fixes: e4244ebddae2 ("platform/chrome: Introduce a new function to check EC features.")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mfd/cros_ec_dev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 81466264f7fc..dfc9f131aabe 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -113,10 +113,10 @@ static int cros_ec_check_features(struct cros_ec_dev *ec, int feature) dev_warn(ec->dev, "cannot get EC features: %d/%d\n", ret, msg->result); memset(ec->features, 0, sizeof(ec->features)); + } else { + memcpy(ec->features, msg->data, sizeof(ec->features)); } - memcpy(ec->features, msg->data, sizeof(ec->features)); - dev_dbg(ec->dev, "EC features %08x %08x\n", ec->features[0], ec->features[1]); |