summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorBodo Stroesser <bstroesser@ts.fujitsu.com>2020-04-08 15:26:09 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2020-04-13 20:00:40 +0200
commit13ef143ddd93a5c8ee1e721683786a82eb9b126d (patch)
tree27abdb5a0cfba1107a7e6a2d1147ad33b5102af7 /drivers
parentscsi: MAINTAINERS: Update qla2xxx FC-SCSI driver maintainer (diff)
downloadlinux-13ef143ddd93a5c8ee1e721683786a82eb9b126d.tar.xz
linux-13ef143ddd93a5c8ee1e721683786a82eb9b126d.zip
scsi: target: Write NULL to *port_nexus_ptr if no ISID
This patch fixes a minor flaw that could be triggered by a PR OUT RESERVE on iSCSI, if TRANSPORT IDs with and without ISID are used in the same command. In case an ISCSI Transport ID has no ISID, port_nexus_ptr was not used to write NULL, so value from previous call might persist. I don't know if that ever could happen, but with the change the code is cleaner, I think. Link: https://lore.kernel.org/r/20200408132610.14623-2-bstroesser@ts.fujitsu.com Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com> Reviewed-by: Mike Christie <mchristi@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/target/target_core_fabric_lib.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c
index 6b4b354c88aa..f5f673e128ef 100644
--- a/drivers/target/target_core_fabric_lib.c
+++ b/drivers/target/target_core_fabric_lib.c
@@ -341,7 +341,8 @@ static char *iscsi_parse_pr_out_transport_id(
*p = tolower(*p);
p++;
}
- }
+ } else
+ *port_nexus_ptr = NULL;
return &buf[4];
}