diff options
| author | Tudor Ambarus <tudor.ambarus@microchip.com> | 2021-12-15 12:01:05 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-01-05 11:20:03 +0100 |
| commit | e6af9b05bec63cd4d1de2a33968cd0be2a91282a (patch) | |
| tree | ef9edc0e777c617f67aefbbab7bf4c8f054f50be /drivers | |
| parent | dmaengine: at_xdmac: Don't start transactions at tx_submit level (diff) | |
| download | linux-e6af9b05bec63cd4d1de2a33968cd0be2a91282a.tar.xz linux-e6af9b05bec63cd4d1de2a33968cd0be2a91282a.zip | |
dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending
Cyclic channels must too call issue_pending in order to start a transfer.
Start the transfer in issue_pending regardless of the type of channel.
This wrongly worked before, because in the past the transfer was started
at tx_submit level when only a desc in the transfer list.
Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211215110115.191749-3-tudor.ambarus@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/dma/at_xdmac.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4ff12b083136..c3d3e1270236 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1778,11 +1778,9 @@ static void at_xdmac_issue_pending(struct dma_chan *chan) dev_dbg(chan2dev(&atchan->chan), "%s\n", __func__); - if (!at_xdmac_chan_is_cyclic(atchan)) { - spin_lock_irqsave(&atchan->lock, flags); - at_xdmac_advance_work(atchan); - spin_unlock_irqrestore(&atchan->lock, flags); - } + spin_lock_irqsave(&atchan->lock, flags); + at_xdmac_advance_work(atchan); + spin_unlock_irqrestore(&atchan->lock, flags); return; } |