summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2023-08-31 06:14:14 +0200
committerDaniel Lezcano <daniel.lezcano@linaro.org>2023-10-11 12:06:41 +0200
commitfd73c011a123a66d88998f356c920d33d87524cf (patch)
treeb2cac460c21d83a5890ae15caab57fddc0688184 /drivers
parentdrivers/clocksource/timer-ti-dm: Don't call clk_get_rate() in stop function (diff)
downloadlinux-fd73c011a123a66d88998f356c920d33d87524cf.tar.xz
linux-fd73c011a123a66d88998f356c920d33d87524cf.zip
clocksource/drivers/sun5i: Remove surplus dev_err() when using platform_get_irq()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/clocksource/timer-sun5i.c:260:2-9: line 260 is redundant because platform_get_irq() already prints an error Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20230831041414.66434-1-yang.lee@linux.alibaba.com
Diffstat (limited to 'drivers')
-rw-r--r--drivers/clocksource/timer-sun5i.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
index 69fee3540d37..0d229a9058da 100644
--- a/drivers/clocksource/timer-sun5i.c
+++ b/drivers/clocksource/timer-sun5i.c
@@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "Can't get IRQ\n");
+ if (irq < 0)
return irq;
- }
clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(clk)) {