diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-12-08 14:37:34 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-12 10:53:10 +0100 |
| commit | 3dfe3486c1cd4f82b466b7d307f23777137b8acc (patch) | |
| tree | 6c1e68cafe96ba74fd88fed9715a66b0578ed67f /drivers | |
| parent | net/tunnel: wait until all sk_user_data reader finish before releasing the sock (diff) | |
| download | linux-3dfe3486c1cd4f82b466b7d307f23777137b8acc.tar.xz linux-3dfe3486c1cd4f82b466b7d307f23777137b8acc.zip | |
net: apple: mace: don't call dev_kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.
It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.
In this case, dev_kfree_skb() is called in mace_tx_timeout() to drop
the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/apple/mace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c index d0a771b65e88..fd1b008b7208 100644 --- a/drivers/net/ethernet/apple/mace.c +++ b/drivers/net/ethernet/apple/mace.c @@ -846,7 +846,7 @@ static void mace_tx_timeout(struct timer_list *t) if (mp->tx_bad_runt) { mp->tx_bad_runt = 0; } else if (i != mp->tx_fill) { - dev_kfree_skb(mp->tx_bufs[i]); + dev_kfree_skb_irq(mp->tx_bufs[i]); if (++i >= N_TX_RING) i = 0; mp->tx_empty = i; |