diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-09-07 11:53:15 +0200 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2023-10-29 19:45:03 +0100 |
| commit | 4b2b39f9395bc66c616d8d5a83642950fc3719b1 (patch) | |
| tree | cb586be3dd4483db5a355587af62a68e3f5f80d2 /drivers | |
| parent | Watchdog: marvell_gti_wdt: Remove redundant dev_err_probe() for platform_get_... (diff) | |
| download | linux-4b2b39f9395bc66c616d8d5a83642950fc3719b1.tar.xz linux-4b2b39f9395bc66c616d8d5a83642950fc3719b1.zip | |
watchdog: marvell_gti_wdt: Fix error code in probe()
This error path accidentally returns success. Return -EINVAL instead.
Fixes: ef9e7fe2c890 ("Watchdog: Add marvell GTI watchdog driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Bharat Bhushan <bbhushan2@marvell.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/af326fd7-ac71-43a1-b7de-81779b61d242@moroto.mountain
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/watchdog/marvell_gti_wdt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/marvell_gti_wdt.c b/drivers/watchdog/marvell_gti_wdt.c index d5a1ff91d423..e835618e6be3 100644 --- a/drivers/watchdog/marvell_gti_wdt.c +++ b/drivers/watchdog/marvell_gti_wdt.c @@ -271,7 +271,7 @@ static int gti_wdt_probe(struct platform_device *pdev) &wdt_idx); if (!err) { if (wdt_idx >= priv->data->gti_num_timers) - return dev_err_probe(&pdev->dev, err, + return dev_err_probe(&pdev->dev, -EINVAL, "GTI wdog timer index not valid"); priv->wdt_timer_idx = wdt_idx; |