summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorFrancesco Dolcini <francesco.dolcini@toradex.com>2023-05-12 15:14:34 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-05-13 11:08:09 +0200
commit5e1617210aede9f1b91bb9819c93097b6da481f9 (patch)
tree31c452780c39ff0313bde063698c63f20092ee8e /drivers
parentusb: gadget: drop superfluous ':' in doc string (diff)
downloadlinux-5e1617210aede9f1b91bb9819c93097b6da481f9.tar.xz
linux-5e1617210aede9f1b91bb9819c93097b6da481f9.zip
Revert "usb: gadget: udc: core: Prevent redundant calls to pullup"
This reverts commit a3afbf5cc887fc3401f012fe629810998ed61859. This depends on commit 0db213ea8eed ("usb: gadget: udc: core: Invoke usb_gadget_connect only when started") that introduces a regression, revert it till the issue is fixed. Cc: stable@vger.kernel.org Reported-by: Stephan Gerhold <stephan@gerhold.net> Reported-by: Francesco Dolcini <francesco.dolcini@toradex.com> Link: https://lore.kernel.org/all/ZF4BvgsOyoKxdPFF@francesco-nb.int.toradex.com/ Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> Link: https://lore.kernel.org/r/20230512131435.205464-2-francesco@dolcini.it Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/gadget/udc/core.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index 4641153e9706..583c339876ab 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -703,9 +703,6 @@ static int usb_gadget_connect_locked(struct usb_gadget *gadget)
goto out;
}
- if (gadget->connected)
- goto out;
-
if (gadget->deactivated || !gadget->udc->started) {
/*
* If gadget is deactivated we only save new state.