diff options
| author | Zev Weiss <zev@bewilderbeest.net> | 2023-02-02 03:18:25 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2023-02-03 16:27:25 +0100 |
| commit | f00093608fa790580da309bb9feb5108fbe7c331 (patch) | |
| tree | 462d19b64dfe38d71caf22ce20341624f16a424d /drivers | |
| parent | hwmon: (nct6775) Fix incorrect parenthesization in nct6775_write_fan_div() (diff) | |
| download | linux-f00093608fa790580da309bb9feb5108fbe7c331.tar.xz linux-f00093608fa790580da309bb9feb5108fbe7c331.zip | |
hwmon: (peci/cputemp) Fix off-by-one in coretemp_label allocation
The find_last_bit() call produces the index of the highest-numbered
core in core_mask; because cores are numbered from zero, the number of
elements we need to allocate is one more than that.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Cc: stable@kernel.org # v5.18
Fixes: bf3608f338e9 ("hwmon: peci: Add cputemp driver")
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Link: https://lore.kernel.org/r/20230202021825.21486-1-zev@bewilderbeest.net
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/hwmon/peci/cputemp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/peci/cputemp.c b/drivers/hwmon/peci/cputemp.c index 57470fda5f6c..30850a479f61 100644 --- a/drivers/hwmon/peci/cputemp.c +++ b/drivers/hwmon/peci/cputemp.c @@ -402,7 +402,7 @@ static int create_temp_label(struct peci_cputemp *priv) unsigned long core_max = find_last_bit(priv->core_mask, CORE_NUMS_MAX); int i; - priv->coretemp_label = devm_kzalloc(priv->dev, core_max * sizeof(char *), GFP_KERNEL); + priv->coretemp_label = devm_kzalloc(priv->dev, (core_max + 1) * sizeof(char *), GFP_KERNEL); if (!priv->coretemp_label) return -ENOMEM; |