diff options
| author | Christian 'Ansuel' Marangi <ansuelsmth@gmail.com> | 2022-06-14 13:06:59 +0200 |
|---|---|---|
| committer | Chanwoo Choi <cw00.choi@samsung.com> | 2022-06-29 22:11:17 +0200 |
| commit | 57e00b40033a376de3f3cf0bb9bf7590d2dd679d (patch) | |
| tree | a91b93798e013ff7c8c95739a43148aae7318a1a /drivers | |
| parent | Linux 5.19-rc4 (diff) | |
| download | linux-57e00b40033a376de3f3cf0bb9bf7590d2dd679d.tar.xz linux-57e00b40033a376de3f3cf0bb9bf7590d2dd679d.zip | |
PM / devfreq: Fix kernel panic with cpu based scaling to passive gov
The cpufreq passive register notifier can PROBE_DEFER and the devfreq
struct is freed and then reallocaed on probe retry.
The current logic assume that the code can't PROBE_DEFER so the devfreq
struct in the this variable in devfreq_passive_data is assumed to be
(if already set) always correct.
This cause kernel panic as the code try to access the wrong address.
To correctly handle this, update the this variable in
devfreq_passive_data to the devfreq reallocated struct.
Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/devfreq/governor_passive.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c index 72c67979ebe1..091a69e1f487 100644 --- a/drivers/devfreq/governor_passive.c +++ b/drivers/devfreq/governor_passive.c @@ -407,8 +407,7 @@ static int devfreq_passive_event_handler(struct devfreq *devfreq, if (!p_data) return -EINVAL; - if (!p_data->this) - p_data->this = devfreq; + p_data->this = devfreq; switch (event) { case DEVFREQ_GOV_START: |