summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-12-01 22:55:29 +0100
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2014-12-04 19:00:17 +0100
commitb59113845f76b8b21946563ee538a580fc972c6c (patch)
treebcbfe0eb0f780bb9ff9ba56f0a10cf1dfef16d7d /drivers
parent[media] lirc_zilog: Deletion of unnecessary checks before vfree() (diff)
downloadlinux-b59113845f76b8b21946563ee538a580fc972c6c.tar.xz
linux-b59113845f76b8b21946563ee538a580fc972c6c.zip
[media] mn88473: Remove uneeded check before release_firmware()
The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/staging/media/mn88473/mn88473.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c
index 165933540b34..52180bbc3616 100644
--- a/drivers/staging/media/mn88473/mn88473.c
+++ b/drivers/staging/media/mn88473/mn88473.c
@@ -262,8 +262,7 @@ static int mn88473_init(struct dvb_frontend *fe)
return 0;
err:
- if (fw)
- release_firmware(fw);
+ release_firmware(fw);
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;