diff options
| author | Tadeusz Struk <tadeusz.struk@intel.com> | 2016-06-09 16:51:45 +0200 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2016-06-18 02:11:27 +0200 |
| commit | 93dd0a097859a174817ea94ec55bfc29c5706454 (patch) | |
| tree | 11187370374edd6dabd62e9c06ebcf040cbcd89c /drivers | |
| parent | IB/qib: Prevent context loss (diff) | |
| download | linux-93dd0a097859a174817ea94ec55bfc29c5706454.tar.xz linux-93dd0a097859a174817ea94ec55bfc29c5706454.zip | |
IB/hfi1: Fix potential NULL ptr dereference
This fixes potential NULL ptr dereference because IS_ERR(dd) doesn't
handle NULL. Fix the issue by initializing the pointer with a not NULL
error code.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/infiniband/hw/hfi1/init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c index 0d28a5a40fae..eed971ccd2a1 100644 --- a/drivers/infiniband/hw/hfi1/init.c +++ b/drivers/infiniband/hw/hfi1/init.c @@ -1383,7 +1383,7 @@ static void postinit_cleanup(struct hfi1_devdata *dd) static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) { int ret = 0, j, pidx, initfail; - struct hfi1_devdata *dd = NULL; + struct hfi1_devdata *dd = ERR_PTR(-EINVAL); struct hfi1_pportdata *ppd; /* First, lock the non-writable module parameters */ |