diff options
| author | David Daney <ddaney@caviumnetworks.com> | 2010-05-05 15:03:11 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-06 06:22:34 +0200 |
| commit | b635e06993076c3c8f8cc766b183be7da3baafdb (patch) | |
| tree | 0195c38348de31f61379e1cf78e8b6ffb2b65273 /drivers | |
| parent | netdev: octeon_mgmt: Fix race manipulating irq bits. (diff) | |
| download | linux-b635e06993076c3c8f8cc766b183be7da3baafdb.tar.xz linux-b635e06993076c3c8f8cc766b183be7da3baafdb.zip | |
netdev: octeon_mgmt: Free TX skbufs in a timely manner.
We also reduce the high water mark to 1 so skbufs are not stranded for
long periods of time. Since we are cleaning after each packet, no
need to do it in the transmit path.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/octeon/octeon_mgmt.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/octeon/octeon_mgmt.c b/drivers/net/octeon/octeon_mgmt.c index 633fa89c442f..3cf6f62502c8 100644 --- a/drivers/net/octeon/octeon_mgmt.c +++ b/drivers/net/octeon/octeon_mgmt.c @@ -832,9 +832,9 @@ static int octeon_mgmt_open(struct net_device *netdev) mix_irhwm.s.irhwm = 0; cvmx_write_csr(CVMX_MIXX_IRHWM(port), mix_irhwm.u64); - /* Interrupt when we have 5 or more packets to clean. */ + /* Interrupt when we have 1 or more packets to clean. */ mix_orhwm.u64 = 0; - mix_orhwm.s.orhwm = 5; + mix_orhwm.s.orhwm = 1; cvmx_write_csr(CVMX_MIXX_ORHWM(port), mix_orhwm.u64); /* Enable receive and transmit interrupts */ @@ -995,7 +995,6 @@ static int octeon_mgmt_xmit(struct sk_buff *skb, struct net_device *netdev) cvmx_write_csr(CVMX_MIXX_ORING2(port), 1); netdev->trans_start = jiffies; - octeon_mgmt_clean_tx_buffers(p); octeon_mgmt_update_tx_stats(netdev); return NETDEV_TX_OK; } |