summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJonathan Liu <net147@gmail.com>2017-10-10 05:46:13 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-10-17 11:42:51 +0200
commit6ed05c68cbcae42cd52b8e53b66952bfa9c002ce (patch)
tree7d97789b21633155e69e5babc4bc16df3625a1b8 /drivers
parentusb: musb: Check for host-mode using is_host_active() on reset interrupt (diff)
downloadlinux-6ed05c68cbcae42cd52b8e53b66952bfa9c002ce.tar.xz
linux-6ed05c68cbcae42cd52b8e53b66952bfa9c002ce.zip
usb: musb: sunxi: Explicitly release USB PHY on exit
This fixes a kernel oops when unloading the driver due to usb_put_phy being called after usb_phy_generic_unregister when the device is detached. Calling usb_phy_generic_unregister causes x->dev->driver to be NULL in usb_put_phy and results in a NULL pointer dereference. Cc: stable@vger.kernel.org # v4.3+ Signed-off-by: Jonathan Liu <net147@gmail.com> Signed-off-by: Bin Liu <b-liu@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/musb/sunxi.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index c9a09b5bb6e5..dc353e24d53c 100644
--- a/drivers/usb/musb/sunxi.c
+++ b/drivers/usb/musb/sunxi.c
@@ -297,6 +297,8 @@ static int sunxi_musb_exit(struct musb *musb)
if (test_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags))
sunxi_sram_release(musb->controller->parent);
+ devm_usb_put_phy(glue->dev, glue->xceiv);
+
return 0;
}