diff options
| author | Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> | 2020-09-22 21:49:38 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2020-09-23 20:01:47 +0200 |
| commit | 46d2613eae51d527ecaf0e8248a9bfcc0b92aa7e (patch) | |
| tree | d2eb584d8e67da9ec29e72a7784492f2d9e0beba /drivers | |
| parent | nvme-fc: fail new connections to a deleted host or remote port (diff) | |
| download | linux-46d2613eae51d527ecaf0e8248a9bfcc0b92aa7e.tar.xz linux-46d2613eae51d527ecaf0e8248a9bfcc0b92aa7e.zip | |
nvme-core: don't use NVME_NSID_ALL for command effects and supported log
In the function nvme_get_effects_log() it uses NVME_NSID_ALL which has
namespace scope. The command effect log page is controller specific.
Replace NVME_NSID_ALL with 0x00 which specifies the controller scope
instead of namespace scope.
Fixes: 84fef62d135b ("nvme: check admin passthru command effects")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=209287
Reported-by: Huai-Cheng Kuo <hh81478072@gmail.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/nvme/host/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 4cea14c18a6d..53c93836c7c6 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3041,7 +3041,7 @@ static int nvme_get_effects_log(struct nvme_ctrl *ctrl, u8 csi, if (!cel) return -ENOMEM; - ret = nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_CMD_EFFECTS, 0, csi, + ret = nvme_get_log(ctrl, 0x00, NVME_LOG_CMD_EFFECTS, 0, csi, &cel->log, sizeof(cel->log), 0); if (ret) { kfree(cel); |