summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorSalva Peiró <speiro@ai2.upv.es>2013-12-17 10:06:30 +0100
committerDavid S. Miller <davem@davemloft.net>2013-12-19 21:09:38 +0100
commit8e3fbf870481eb53b2d3a322d1fc395ad8b367ed (patch)
treeeaad28ff58992b67a2095cbd41d6fff46f1a1b82 /drivers
parentdrivers/net/hamradio: Integer overflow in hdlcdrv_ioctl() (diff)
downloadlinux-8e3fbf870481eb53b2d3a322d1fc395ad8b367ed.tar.xz
linux-8e3fbf870481eb53b2d3a322d1fc395ad8b367ed.zip
hamradio/yam: fix info leak in ioctl
The yam_ioctl() code fails to initialise the cmd field of the struct yamdrv_ioctl_cfg. Add an explicit memset(0) before filling the structure to avoid the 4-byte info leak. Signed-off-by: Salva Peiró <speiro@ai2.upv.es> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/hamradio/yam.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 1971411574db..61dd2447e1bb 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1057,6 +1057,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
break;
case SIOCYAMGCFG:
+ memset(&yi, 0, sizeof(yi));
yi.cfg.mask = 0xffffffff;
yi.cfg.iobase = yp->iobase;
yi.cfg.irq = yp->irq;