diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2020-03-02 09:24:48 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2020-03-03 13:33:02 +0100 |
| commit | ca18a852ee3696ea625efa13b1fac3c33f025a53 (patch) | |
| tree | 16b25f36b019e37b7db444db6bc3adc22a958d82 /drivers | |
| parent | gpiolib: Optimize gpiochip_remove() when check for requested line (diff) | |
| download | linux-ca18a852ee3696ea625efa13b1fac3c33f025a53.tar.xz linux-ca18a852ee3696ea625efa13b1fac3c33f025a53.zip | |
gpiolib: Fix inverted check in gpiochip_remove()
The optimization to check for requested lines actually optimized for the
uncomon error case, where one of the GPIO lines is still in use.
Hence the error message must be printed when the loop is terminated
early, not when it went through all available GPIO lines.
Fixes: 869233f81337bfb3 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200302082448.11795-1-geert+renesas@glider.be
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpio/gpiolib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 2253ab495349..0879731caf25 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1823,7 +1823,7 @@ void gpiochip_remove(struct gpio_chip *chip) } spin_unlock_irqrestore(&gpio_lock, flags); - if (i == gdev->ngpio) + if (i != gdev->ngpio) dev_crit(&gdev->dev, "REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED\n"); |