diff options
| author | Sagi Grimberg <sagi@grimberg.me> | 2020-10-22 04:15:31 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2020-11-03 10:26:02 +0100 |
| commit | 0a8a2c85b83589a5c10bc5564b796836bf4b4984 (patch) | |
| tree | a613dd4716c5f5741de6f17f8b6090b5940a7001 /drivers | |
| parent | nvme-rdma: avoid repeated request completion (diff) | |
| download | linux-0a8a2c85b83589a5c10bc5564b796836bf4b4984.tar.xz linux-0a8a2c85b83589a5c10bc5564b796836bf4b4984.zip | |
nvme-tcp: avoid repeated request completion
The request may be executed asynchronously, and rq->state may be
changed to IDLE. To avoid repeated request completion, only
MQ_RQ_COMPLETE of rq->state is checked in nvme_tcp_complete_timed_out.
It is not safe, so need adding check IDLE for rq->state.
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Chao Leng <lengchao@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/nvme/host/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 19f86ea547bb..c0c33320fe65 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -2168,7 +2168,7 @@ static void nvme_tcp_complete_timed_out(struct request *rq) struct nvme_ctrl *ctrl = &req->queue->ctrl->ctrl; nvme_tcp_stop_queue(ctrl, nvme_tcp_queue_id(req->queue)); - if (!blk_mq_request_completed(rq)) { + if (blk_mq_request_started(rq) && !blk_mq_request_completed(rq)) { nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD; blk_mq_complete_request(rq); } |