summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorMaxime Ripard <maxime@cerno.tech>2020-06-15 10:40:51 +0200
committerStephen Boyd <sboyd@kernel.org>2020-06-20 02:21:16 +0200
commit9bd43a6184c2559032a2a8675c135abf7777a736 (patch)
tree78486bab0c3b3b89640115254aac8ea772f367c3 /drivers
parentclk: bcm: rpi: Switch to clk_hw_register_clkdev (diff)
downloadlinux-9bd43a6184c2559032a2a8675c135abf7777a736.tar.xz
linux-9bd43a6184c2559032a2a8675c135abf7777a736.zip
clk: bcm: rpi: Make sure the clkdev lookup is removed
The clkdev lookup created for the cpufreq device is never removed if there's an issue later in probe or at module removal time. Let's convert to the managed variant of the clk_hw_register_clkdev function to make sure it happens. Cc: Michael Turquette <mturquette@baylibre.com> Cc: linux-clk@vger.kernel.org Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Reviewed-by: Stephen Boyd <sboyd@kernel.org> Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Signed-off-by: Maxime Ripard <maxime@cerno.tech> Link: https://lore.kernel.org/r/075e2c6d315eccdaf8fb72b320712b86e6c25b22.1592210452.git-series.maxime@cerno.tech Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/clk/bcm/clk-raspberrypi.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 23f06618a356..a20492fade6a 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -245,8 +245,9 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
return ret;
}
- ret = clk_hw_register_clkdev(&raspberrypi_clk_pllb_arm.hw,
- NULL, "cpu0");
+ ret = devm_clk_hw_register_clkdev(rpi->dev,
+ &raspberrypi_clk_pllb_arm.hw,
+ NULL, "cpu0");
if (ret) {
dev_err(rpi->dev, "Failed to initialize clkdev\n");
return ret;