diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-04-03 15:06:08 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-04-11 19:37:11 +0200 |
| commit | a9f17d0c0778dd971dc9770fa0a2085a41d8c5e4 (patch) | |
| tree | a3059b2a2eaddaf3e93340202c4db2ca05873db8 /drivers | |
| parent | phy: samsung: exynos5250-sata: fix missing device put in probe error paths (diff) | |
| download | linux-a9f17d0c0778dd971dc9770fa0a2085a41d8c5e4.tar.xz linux-a9f17d0c0778dd971dc9770fa0a2085a41d8c5e4.zip | |
phy: ti: tusb1210: Fix an error handling path in tusb1210_probe()
tusb1210_probe_charger_detect() must be undone by a corresponding
tusb1210_remove_charger_detect() in the error handling path, as already
done in the remove function.
Fixes: 48969a5623ed ("phy: ti: tusb1210: Add charger detection")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/07c4926c42243cedb3b6067a241bb486fdda01b5.1648991162.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/phy/ti/phy-tusb1210.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c index c5bd74874f73..c3ab4b69ea68 100644 --- a/drivers/phy/ti/phy-tusb1210.c +++ b/drivers/phy/ti/phy-tusb1210.c @@ -537,12 +537,18 @@ static int tusb1210_probe(struct ulpi *ulpi) tusb1210_probe_charger_detect(tusb); tusb->phy = ulpi_phy_create(ulpi, &phy_ops); - if (IS_ERR(tusb->phy)) - return PTR_ERR(tusb->phy); + if (IS_ERR(tusb->phy)) { + ret = PTR_ERR(tusb->phy); + goto err_remove_charger; + } phy_set_drvdata(tusb->phy, tusb); ulpi_set_drvdata(ulpi, tusb); return 0; + +err_remove_charger: + tusb1210_remove_charger_detect(tusb); + return ret; } static void tusb1210_remove(struct ulpi *ulpi) |