diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-09-16 16:07:26 +0200 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2024-10-02 01:27:50 +0200 |
| commit | eb8333673e1ebc2418980b664a84c91b4e98afc4 (patch) | |
| tree | ace96d76cede8215f89db3d3f18ffa977577ec17 /drivers | |
| parent | Linux 6.12-rc1 (diff) | |
| download | linux-eb8333673e1ebc2418980b664a84c91b4e98afc4.tar.xz linux-eb8333673e1ebc2418980b664a84c91b4e98afc4.zip | |
OPP: fix error code in dev_pm_opp_set_config()
This is an error path so set the error code. Smatch complains about the
current code:
drivers/opp/core.c:2660 dev_pm_opp_set_config()
error: uninitialized symbol 'ret'.
Fixes: e37440e7e2c2 ("OPP: Call dev_pm_opp_set_opp() for required OPPs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/3f3660af-4ea0-4a89-b3b7-58de7b16d7a5@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/opp/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 494f8860220d..3aa18737470f 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -2630,8 +2630,10 @@ int dev_pm_opp_set_config(struct device *dev, struct dev_pm_opp_config *config) /* Attach genpds */ if (config->genpd_names) { - if (config->required_devs) + if (config->required_devs) { + ret = -EINVAL; goto err; + } ret = _opp_attach_genpd(opp_table, dev, config->genpd_names, config->virt_devs); |