diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2016-07-13 22:40:14 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2016-07-15 21:31:31 +0200 |
| commit | 885848186fbc2d1d8fb6d2fdc2156638ae289a46 (patch) | |
| tree | e027bde79fc5704a6e462466d344336bd83b704b /firmware/keyspan | |
| parent | nfsd/blocklayout: Make sure calculate signature/designator length aligned (diff) | |
| download | linux-885848186fbc2d1d8fb6d2fdc2156638ae289a46.tar.xz linux-885848186fbc2d1d8fb6d2fdc2156638ae289a46.zip | |
nfsd: Close race between nfsd4_release_lockowner and nfsd4_lock
nfsd4_release_lockowner finds a lock owner that has no lock state,
and drops cl_lock. Then release_lockowner picks up cl_lock and
unhashes the lock owner.
During the window where cl_lock is dropped, I don't see anything
preventing a concurrent nfsd4_lock from finding that same lock owner
and adding lock state to it.
Move release_lockowner() into nfsd4_release_lockowner and hang onto
the cl_lock until after the lock owner's state cannot be found
again.
Found by inspection, we don't currently have a reproducer.
Fixes: 2c41beb0e5cf ("nfsd: reduce cl_lock thrashing in ... ")
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'firmware/keyspan')
0 files changed, 0 insertions, 0 deletions