diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-12-01 08:04:12 +0100 |
|---|---|---|
| committer | Dominique Martinet <asmadeus@codewreck.org> | 2020-12-01 08:18:57 +0100 |
| commit | dfd375864ac1e2ee60ed2d61820697ac01642f80 (patch) | |
| tree | 8a5adb231fd70c398fc785e3a637eb8c97274562 /fs/9p/fid.c | |
| parent | 9p: Fix writeback fid incorrectly being attached to dentry (diff) | |
| download | linux-dfd375864ac1e2ee60ed2d61820697ac01642f80.tar.xz linux-dfd375864ac1e2ee60ed2d61820697ac01642f80.zip | |
9p: Uninitialized variable in v9fs_writeback_fid()
If v9fs_fid_lookup_with_uid() fails then "fid" is not initialized.
The v9fs_fid_lookup_with_uid() can't return NULL. If it returns an
error pointer then we can still pass that to clone_fid() and it will
return the error pointer back again.
Fixes: 6636b6dcc3db ("9p: add refcount to p9_fid struct")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Diffstat (limited to 'fs/9p/fid.c')
| -rw-r--r-- | fs/9p/fid.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/9p/fid.c b/fs/9p/fid.c index 50118ec72a92..79837f1b1c91 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c @@ -302,8 +302,7 @@ struct p9_fid *v9fs_writeback_fid(struct dentry *dentry) struct p9_fid *fid, *ofid; ofid = v9fs_fid_lookup_with_uid(dentry, GLOBAL_ROOT_UID, 0); - if (ofid && !IS_ERR(ofid)) - fid = clone_fid(ofid); + fid = clone_fid(ofid); if (IS_ERR(fid)) goto error_out; p9_client_clunk(ofid); |