diff options
author | Tejun Heo <tj@kernel.org> | 2014-06-28 14:10:14 +0200 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2014-06-28 14:10:14 +0200 |
commit | 9a1049da9bd2cd83fe11d46433e603c193aa9c71 (patch) | |
tree | 007d2843abf0f064c294659334e69e297ffc2b74 /fs/afs | |
parent | percpu-refcount: use unsigned long for pcpu_count pointer (diff) | |
download | linux-9a1049da9bd2cd83fe11d46433e603c193aa9c71.tar.xz linux-9a1049da9bd2cd83fe11d46433e603c193aa9c71.zip |
percpu-refcount: require percpu_ref to be exited explicitly
Currently, a percpu_ref undoes percpu_ref_init() automatically by
freeing the allocated percpu area when the percpu_ref is killed.
While seemingly convenient, this has the following niggles.
* It's impossible to re-init a released reference counter without
going through re-allocation.
* In the similar vein, it's impossible to initialize a percpu_ref
count with static percpu variables.
* We need and have an explicit destructor anyway for failure paths -
percpu_ref_cancel_init().
This patch removes the automatic percpu counter freeing in
percpu_ref_kill_rcu() and repurposes percpu_ref_cancel_init() into a
generic destructor now named percpu_ref_exit(). percpu_ref_destroy()
is considered but it gets confusing with percpu_ref_kill() while
"exit" clearly indicates that it's the counterpart of
percpu_ref_init().
All percpu_ref_cancel_init() users are updated to invoke
percpu_ref_exit() instead and explicit percpu_ref_exit() calls are
added to the destruction path of all percpu_ref users.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Benjamin LaHaise <bcrl@kvack.org>
Cc: Kent Overstreet <kmo@daterainc.com>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Benjamin LaHaise <bcrl@kvack.org>
Cc: Nicholas A. Bellinger <nab@linux-iscsi.org>
Cc: Li Zefan <lizefan@huawei.com>
Diffstat (limited to 'fs/afs')
0 files changed, 0 insertions, 0 deletions