diff options
| author | David Howells <dhowells@redhat.com> | 2020-06-09 17:15:45 +0200 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-06-09 18:21:03 +0200 |
| commit | 9ca0652596bd924a4023db6b429a0aaaea629826 (patch) | |
| tree | c7a6d63bc4d08641ff1a488f114ea6fc7314f6f8 /fs/afs | |
| parent | afs: Fix file locking (diff) | |
| download | linux-9ca0652596bd924a4023db6b429a0aaaea629826.tar.xz linux-9ca0652596bd924a4023db6b429a0aaaea629826.zip | |
afs: Fix use of BUG()
Fix afs_compare_addrs() to use WARN_ON(1) instead of BUG() and return 1
(ie. srx_a > srx_b).
There's no point trying to put actual error handling in as this should not
occur unless a new transport address type is allowed by AFS. And even if
it does, in this particular case, it'll just never match unknown types of
addresses. This BUG() was more of a 'you need to add a case here'
indicator.
Reported-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'fs/afs')
| -rw-r--r-- | fs/afs/vl_alias.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/afs/vl_alias.c b/fs/afs/vl_alias.c index 093895c49c21..136fc6164e00 100644 --- a/fs/afs/vl_alias.c +++ b/fs/afs/vl_alias.c @@ -73,7 +73,8 @@ static int afs_compare_addrs(const struct sockaddr_rxrpc *srx_a, } default: - BUG(); + WARN_ON(1); + diff = 1; } out: |