diff options
| author | Dan Williams <djbw@fb.com> | 2012-08-29 07:12:10 +0200 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2012-09-24 10:17:49 +0200 |
| commit | bc3f02a795d3b4faa99d37390174be2a75d091bd (patch) | |
| tree | b1a5b23444144338e4c1937029f55940f82c638d /fs/aio.c | |
| parent | [SCSI] ibmvscsi: Fix host config length field overflow (diff) | |
| download | linux-bc3f02a795d3b4faa99d37390174be2a75d091bd.tar.xz linux-bc3f02a795d3b4faa99d37390174be2a75d091bd.zip | |
[SCSI] scsi_remove_target: fix softlockup regression on hot remove
John reports:
BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202]
[..]
Call Trace:
[<ffffffff8141782a>] scsi_remove_target+0xda/0x1f0
[<ffffffff81421de5>] sas_rphy_remove+0x55/0x60
[<ffffffff81421e01>] sas_rphy_delete+0x11/0x20
[<ffffffff81421e35>] sas_port_delete+0x25/0x160
[<ffffffff814549a3>] mptsas_del_end_device+0x183/0x270
...introduced by commit 3b661a9 "[SCSI] fix hot unplug vs async scan race".
Don't restart lookup of more stargets in the multi-target case, just
arrange to traverse the list once, on the assumption that new targets
are always added at the end. There is no guarantee that the target will
change state in scsi_target_reap() so we can end up spinning if we
restart.
Cc: <stable@vger.kernel.org>
Acked-by: Jack Wang <jack_wang@usish.com>
LKML-Reference: <CAEhu1-6wq1YsNiscGMwP4ud0Q+MrViRzv=kcWCQSBNc8c68N5Q@mail.gmail.com>
Reported-by: John Drescher <drescherjm@gmail.com>
Tested-by: John Drescher <drescherjm@gmail.com>
Signed-off-by: Dan Williams <djbw@fb.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'fs/aio.c')
0 files changed, 0 insertions, 0 deletions