diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2017-09-11 15:30:15 +0200 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2017-09-12 17:22:20 +0200 |
| commit | 939ae4efd51c627da270af74ef069db5124cb5b0 (patch) | |
| tree | 3fae925cafeed10a9f2e1b8c8b717601df4dbad0 /fs/attr.c | |
| parent | ovl: don't allow writing ioctl on lower layer (diff) | |
| download | linux-939ae4efd51c627da270af74ef069db5124cb5b0.tar.xz linux-939ae4efd51c627da270af74ef069db5124cb5b0.zip | |
ovl: fix false positive ESTALE on lookup
Commit b9ac5c274b8c ("ovl: hash overlay non-dir inodes by copy up origin")
verifies that the origin lower inode stored in the overlayfs inode matched
the inode of a copy up origin dentry found by lookup.
There is a false positive result in that check when lower fs does not
support file handles and copy up origin cannot be followed by file handle
at lookup time.
The false negative happens when finding an overlay inode in cache on a
copied up overlay dentry lookup. The overlay inode still 'remembers' the
copy up origin inode, but the copy up origin dentry is not available for
verification.
Relax the check in case copy up origin dentry is not available.
Fixes: b9ac5c274b8c ("ovl: hash overlay non-dir inodes by copy up...")
Cc: <stable@vger.kernel.org> # v4.13
Reported-by: Jordi Pujol <jordipujolp@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/attr.c')
0 files changed, 0 insertions, 0 deletions