diff options
| author | Ian Kent <raven@themaw.net> | 2016-10-11 22:52:39 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-10-12 00:06:31 +0200 |
| commit | 1574fa7beb9f71a60b5b8f2532ca69d3153ded79 (patch) | |
| tree | 979e92f064fa00700c171e8b6083786c8ffe7273 /fs/autofs4 | |
| parent | autofs: add WARN_ON(1) for non dir/link inode case (diff) | |
| download | linux-1574fa7beb9f71a60b5b8f2532ca69d3153ded79.tar.xz linux-1574fa7beb9f71a60b5b8f2532ca69d3153ded79.zip | |
autofs: remove ino free in autofs4_dir_symlink()
The inode allocation failure case in autofs4_dir_symlink() frees the
autofs dentry info of the dentry without setting ->d_fsdata to NULL.
That could lead to a double free so just get rid of the free and leave it
to ->d_release().
Link: http://lkml.kernel.org/r/20160812024759.12352.10653.stgit@pluto.themaw.net
Signed-off-by: Ian Kent <raven@themaw.net>
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/autofs4')
| -rw-r--r-- | fs/autofs4/root.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 623510e84c96..2eebeae75288 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c @@ -577,8 +577,6 @@ static int autofs4_dir_symlink(struct inode *dir, inode = autofs4_get_inode(dir->i_sb, S_IFLNK | 0555); if (!inode) { kfree(cp); - if (!dentry->d_fsdata) - kfree(ino); return -ENOMEM; } inode->i_private = cp; |