diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2024-06-17 15:09:52 +0200 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-06-20 00:27:23 +0200 |
| commit | 3727ca56049d893859b68f70e50092250de79f28 (patch) | |
| tree | c22f243cdeff31c06c989980dc75c89e3084112d /fs/bcachefs | |
| parent | bcachefs: Fix array-index-out-of-bounds (diff) | |
| download | linux-3727ca56049d893859b68f70e50092250de79f28.tar.xz linux-3727ca56049d893859b68f70e50092250de79f28.zip | |
bcachefs: Fix a locking bug in the do_discard_fast() path
We can't discard a bucket while it's still open; this needs the
bucket_is_open_safe() version, which takes the open_buckets lock.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs')
| -rw-r--r-- | fs/bcachefs/alloc_background.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c index c4b6601f5b74..d2241f2b40fe 100644 --- a/fs/bcachefs/alloc_background.c +++ b/fs/bcachefs/alloc_background.c @@ -882,7 +882,7 @@ int bch2_trigger_alloc(struct btree_trans *trans, closure_wake_up(&c->freelist_wait); if (statechange(a->data_type == BCH_DATA_need_discard) && - !bch2_bucket_is_open(c, new.k->p.inode, new.k->p.offset) && + !bch2_bucket_is_open_safe(c, new.k->p.inode, new.k->p.offset) && bucket_flushed(new_a)) bch2_discard_one_bucket_fast(c, new.k->p); |