diff options
author | Qu Wenruo <wqu@suse.com> | 2019-07-01 07:12:46 +0200 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2019-07-17 17:03:28 +0200 |
commit | 42c16da6d684391db83788eb680accd84f6c2083 (patch) | |
tree | fa1892839dfeb4163901a3789a4bc589f2216f38 /fs/befs/btree.h | |
parent | btrfs: fix memory leak of path on error return path (diff) | |
download | linux-42c16da6d684391db83788eb680accd84f6c2083.tar.xz linux-42c16da6d684391db83788eb680accd84f6c2083.zip |
btrfs: inode: Don't compress if NODATASUM or NODATACOW set
As btrfs(5) specified:
Note
If nodatacow or nodatasum are enabled, compression is disabled.
If NODATASUM or NODATACOW set, we should not compress the extent.
Normally NODATACOW is detected properly in run_delalloc_range() so
compression won't happen for NODATACOW.
However for NODATASUM we don't have any check, and it can cause
compressed extent without csum pretty easily, just by:
mkfs.btrfs -f $dev
mount $dev $mnt -o nodatasum
touch $mnt/foobar
mount -o remount,datasum,compress $mnt
xfs_io -f -c "pwrite 0 128K" $mnt/foobar
And in fact, we have a bug report about corrupted compressed extent
without proper data checksum so even RAID1 can't recover the corruption.
(https://bugzilla.kernel.org/show_bug.cgi?id=199707)
Running compression without proper checksum could cause more damage when
corruption happens, as compressed data could make the whole extent
unreadable, so there is no need to allow compression for
NODATACSUM.
The fix will refactor the inode compression check into two parts:
- inode_can_compress()
As the hard requirement, checked at btrfs_run_delalloc_range(), so no
compression will happen for NODATASUM inode at all.
- inode_need_compress()
As the soft requirement, checked at btrfs_run_delalloc_range() and
compress_file_range().
Reported-by: James Harvey <jamespharvey20@gmail.com>
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/befs/btree.h')
0 files changed, 0 insertions, 0 deletions