summaryrefslogtreecommitdiffstats
path: root/fs/befs/datastream.c
diff options
context:
space:
mode:
authorLuis de Bethencourt <luisbg@osg.samsung.com>2016-07-03 17:29:44 +0200
committerLuis de Bethencourt <luisbg@osg.samsung.com>2016-10-08 11:01:16 +0200
commit4c3897cce0774b6196f59f98a44eed7e011db5aa (patch)
tree68c49115da8af4bfc61fbf685cd22be127500596 /fs/befs/datastream.c
parentbefs: use simpler while loop (diff)
downloadlinux-4c3897cce0774b6196f59f98a44eed7e011db5aa.tar.xz
linux-4c3897cce0774b6196f59f98a44eed7e011db5aa.zip
befs: make consistent use of befs_error()
befs_error() is used in potential errors that could happen in befs to provide informational log messages. befs_debug() is silent when CONFIG_BEFS_DEBUG=no, and very verbose when switched on, which is why it is used for general debugging but not for errors. Fix a few cases where the befs debug utility usage isn't following the expected pattern. To make sure we have consistent information in the logs. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Diffstat (limited to 'fs/befs/datastream.c')
-rw-r--r--fs/befs/datastream.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
index 26cc417cbdce..740fabcd57c0 100644
--- a/fs/befs/datastream.c
+++ b/fs/befs/datastream.c
@@ -275,6 +275,8 @@ befs_find_brun_direct(struct super_block *sb, const befs_data_stream *data,
}
}
+ befs_error(sb, "%s failed to find file block %lu", __func__,
+ (unsigned long)blockno);
befs_debug(sb, "---> %s ERROR", __func__);
return BEFS_ERR;
}
@@ -328,9 +330,10 @@ befs_find_brun_indirect(struct super_block *sb,
for (i = 0; i < indirect.len; i++) {
indirblock = sb_bread(sb, indirblockno + i);
if (indirblock == NULL) {
- befs_debug(sb, "---> %s failed to read "
+ befs_error(sb, "---> %s failed to read "
"disk block %lu from the indirect brun",
__func__, (unsigned long)indirblockno + i);
+ befs_debug(sb, "<--- %s ERROR", __func__);
return BEFS_ERR;
}