diff options
| author | Jan Kara <jack@suse.cz> | 2017-05-19 01:36:22 +0200 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2017-05-25 18:42:25 +0200 |
| commit | 5375023ae1266553a7baa0845e82917d8803f48c (patch) | |
| tree | 740da081851876d4acbeaf602af93f53f13653bb /fs/befs/debug.c | |
| parent | xfs: fix off-by-one on max nr_pages in xfs_find_get_desired_pgoff() (diff) | |
| download | linux-5375023ae1266553a7baa0845e82917d8803f48c.tar.xz linux-5375023ae1266553a7baa0845e82917d8803f48c.zip | |
xfs: Fix missed holes in SEEK_HOLE implementation
XFS SEEK_HOLE implementation could miss a hole in an unwritten extent as
can be seen by the following command:
xfs_io -c "falloc 0 256k" -c "pwrite 0 56k" -c "pwrite 128k 8k"
-c "seek -h 0" file
wrote 57344/57344 bytes at offset 0
56 KiB, 14 ops; 0.0000 sec (49.312 MiB/sec and 12623.9856 ops/sec)
wrote 8192/8192 bytes at offset 131072
8 KiB, 2 ops; 0.0000 sec (70.383 MiB/sec and 18018.0180 ops/sec)
Whence Result
HOLE 139264
Where we can see that hole at offset 56k was just ignored by SEEK_HOLE
implementation. The bug is in xfs_find_get_desired_pgoff() which does
not properly detect the case when pages are not contiguous.
Fix the problem by properly detecting when found page has larger offset
than expected.
CC: stable@vger.kernel.org
Fixes: d126d43f631f996daeee5006714fed914be32368
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/befs/debug.c')
0 files changed, 0 insertions, 0 deletions