diff options
| author | Dave Kleikamp <dave.kleikamp@oracle.com> | 2017-01-11 20:25:00 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2017-01-15 01:32:40 +0100 |
| commit | 4d22c75d4c7b5c5f4bd31054f09103ee490878fd (patch) | |
| tree | a58ff1b3bb440af13026891f6ccb38d36fffcb4c /fs/binfmt_elf.c | |
| parent | aio: fix lock dep warning (diff) | |
| download | linux-4d22c75d4c7b5c5f4bd31054f09103ee490878fd.tar.xz linux-4d22c75d4c7b5c5f4bd31054f09103ee490878fd.zip | |
coredump: Ensure proper size of sparse core files
If the last section of a core file ends with an unmapped or zero page,
the size of the file does not correspond with the last dump_skip() call.
gdb complains that the file is truncated and can be confusing to users.
After all of the vma sections are written, make sure that the file size
is no smaller than the current file position.
This problem can be demonstrated with gdb's bigcore testcase on the
sparc architecture.
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/binfmt_elf.c')
| -rw-r--r-- | fs/binfmt_elf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 29a02daf08a9..422370293cfd 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -2298,6 +2298,7 @@ static int elf_core_dump(struct coredump_params *cprm) goto end_coredump; } } + dump_truncate(cprm); if (!elf_core_write_extra_data(cprm)) goto end_coredump; |