summaryrefslogtreecommitdiffstats
path: root/fs/block_dev.c
diff options
context:
space:
mode:
authorTao Ma <boyu.mt@taobao.com>2012-01-13 02:20:33 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2012-01-13 05:13:12 +0100
commitae55e1aaa7e2e57e538cb98cf617f511c5dc4f73 (patch)
tree3f3981dd7617c656e7a6ba2f3a83a14637c63221 /fs/block_dev.c
parentdrivers/parport/parport_pc.c: fix warnings (diff)
downloadlinux-ae55e1aaa7e2e57e538cb98cf617f511c5dc4f73.tar.xz
linux-ae55e1aaa7e2e57e538cb98cf617f511c5dc4f73.zip
fs/direct-io.c: calculate fs_count correctly in get_more_blocks()
In get_more_blocks(), we use dio_count to calcuate fs_count and do some tricky things to increase fs_count if dio_count isn't aligned. But actually it still has some corner cases that can't be coverd. See the following example: dio_write foo -s 1024 -w 4096 (direct write 4096 bytes at offset 1024). The same goes if the offset isn't aligned to fs_blocksize. In this case, the old calculation counts fs_count to be 1, but actually we will write into 2 different blocks (if fs_blocksize=4096). The old code just works, since it will call get_block twice (and may have to allocate and create extents twice for filesystems like ext4). So we'd better call get_block just once with the proper fs_count. Signed-off-by: Tao Ma <boyu.mt@taobao.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Christoph Hellwig <hch@lst.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/block_dev.c')
0 files changed, 0 insertions, 0 deletions