diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2008-08-01 11:32:04 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-08-01 17:25:26 +0200 |
| commit | 8266602033d6adc6d10cb8811c1fd694767909b0 (patch) | |
| tree | 4a8a87ebf88bf184bf47e8c505df6e94571eb0d7 /fs/block_dev.c | |
| parent | [PATCH] fix races and leaks in vfs_quota_on() users (diff) | |
| download | linux-8266602033d6adc6d10cb8811c1fd694767909b0.tar.xz linux-8266602033d6adc6d10cb8811c1fd694767909b0.zip | |
[PATCH] fix bdev leak in block_dev.c do_open()
Callers expect it to drop reference to bdev on all failure exits.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/block_dev.c')
| -rw-r--r-- | fs/block_dev.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/block_dev.c b/fs/block_dev.c index dcf37cada369..e664b0b70489 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -941,8 +941,10 @@ static int do_open(struct block_device *bdev, struct file *file, int for_part) * hooks: /n/, see "layering violations". */ ret = devcgroup_inode_permission(bdev->bd_inode, perm); - if (ret != 0) + if (ret != 0) { + bdput(bdev); return ret; + } ret = -ENXIO; file->f_mapping = bdev->bd_inode->i_mapping; |