diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2022-12-16 21:15:51 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-02-13 17:50:33 +0100 |
| commit | a6ca692ec22bdac5ae700e82ff575a1b5141fa40 (patch) | |
| tree | 11b34e3988ea02c6abb48301d786ed5044c2c73d /fs/btrfs/disk-io.c | |
| parent | btrfs: zoned: fix uninitialized variable warning in btrfs_get_dev_zones (diff) | |
| download | linux-a6ca692ec22bdac5ae700e82ff575a1b5141fa40.tar.xz linux-a6ca692ec22bdac5ae700e82ff575a1b5141fa40.zip | |
btrfs: fix uninitialized variable warning in run_one_async_start
With -Wmaybe-uninitialized compiler complains about ret being possibly
uninitialized, which isn't possible as the WQ_ constants are set only
from our code, however we can handle the default case and get rid of the
warning.
The value is set to BLK_STS_IOERR so it does not issue any IO and could
be potentially detected, but this is basically a "cannot happen" error.
To catch any problems during development use the assert.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ set the error in default: ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to '')
| -rw-r--r-- | fs/btrfs/disk-io.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 3aa04224315e..7586a8e9b718 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -717,6 +717,10 @@ static void run_one_async_start(struct btrfs_work *work) ret = btrfs_submit_bio_start_direct_io(async->inode, async->bio, async->dio_file_offset); break; + default: + /* Can't happen so return something that would prevent the IO. */ + ret = BLK_STS_IOERR; + ASSERT(0); } if (ret) async->status = ret; |