diff options
| author | Josef Bacik <jbacik@fusionio.com> | 2013-06-06 16:29:40 +0200 |
|---|---|---|
| committer | Chris Mason <chris.mason@fusionio.com> | 2013-06-08 21:07:53 +0200 |
| commit | 7b5ff90ed081787ec0765ceb4fe5ccf5677493a6 (patch) | |
| tree | fd0bffca467dde8ac29405004e8bf81be0725f11 /fs/btrfs/disk-io.c | |
| parent | Merge branch 'for-chris' of git://git.kernel.org/pub/scm/linux/kernel/git/jos... (diff) | |
| download | linux-7b5ff90ed081787ec0765ceb4fe5ccf5677493a6.tar.xz linux-7b5ff90ed081787ec0765ceb4fe5ccf5677493a6.zip | |
Btrfs: don't delete fs_roots until after we cleanup the transaction
We get a use after free if we had a transaction to cleanup since there could be
delayed inodes which refer to their respective fs_root. Thanks
Reported-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
| -rw-r--r-- | fs/btrfs/disk-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index e7b3cb5286a5..bdaa092d6296 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2859,8 +2859,8 @@ fail_qgroup: btrfs_free_qgroup_config(fs_info); fail_trans_kthread: kthread_stop(fs_info->transaction_kthread); - del_fs_roots(fs_info); btrfs_cleanup_transaction(fs_info->tree_root); + del_fs_roots(fs_info); fail_cleaner: kthread_stop(fs_info->cleaner_kthread); |